[GitHub] erisu commented on a change in pull request #507: Gradle updates

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#discussion_r230646452
 
 

 ##########
 File path: test/wrapper.gradle
 ##########
 @@ -1,3 +1,3 @@
 wrapper {
-    gradleVersion = '4.4.1'
+    gradleVersion = '4.6'
 
 Review comment:
   ```suggestion
       gradleVersion = '4.6.0'
   ```
   
   Does this need to be `4.6.0`? In the previous file `bin/templates/project/app/build.gradle` you had written it as 
   
   ```
   wrapper {
       gradleVersion = '4.6.0'
   }
   ```
   but this file was different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org