[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1035: SOLR-13966: Decode lat lon bevor used by RealTimeGetComponent

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1035: SOLR-13966: Decode lat lon bevor used by RealTimeGetComponent
URL: https://github.com/apache/lucene-solr/pull/1035#discussion_r355268146
 
 

 ##########
 File path: solr/core/src/test/org/apache/solr/update/processor/NestedAtomicUpdateTest.java
 ##########
 @@ -709,6 +709,67 @@ private void testBlockAtomicSetToNullOrEmpty(boolean empty) throws Exception {
         "/response/docs/[0]/cat_ss/[1]==\"ccc\"");
   }
 
+  @Test
+  public void testBlockAtomicUpdateWithoutTouchingLatLonPointSpartialField() throws Exception {
 
 Review comment:
   This test appears to be a copy-paste from the one above, but simply adding a latLon field to it.  Nothing more.  Right?  Then lets not approach it this way; we only need one method here.  Comments inside can mention that latLon is here due to this issue (reference JIRA issue).  If you can make this change quickly then it can get into 8.4.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org