You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ps...@apache.org on 2006/03/12 05:48:27 UTC

svn commit: r385244 - in /jakarta/commons/proper/dbcp/trunk/src: java/org/apache/commons/dbcp/PoolingConnection.java test/org/apache/commons/dbcp/TestBasicDataSource.java

Author: psteitz
Date: Sat Mar 11 20:48:26 2006
New Revision: 385244

URL: http://svn.apache.org/viewcvs?rev=385244&view=rev
Log:
Javadoc. Get rid of * imports.

Modified:
    jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java
    jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java

Modified: jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java?rev=385244&r1=385243&r2=385244&view=diff
==============================================================================
--- jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java (original)
+++ jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingConnection.java Sat Mar 11 20:48:26 2006
@@ -16,10 +16,17 @@
 
 package org.apache.commons.dbcp;
 
-import java.sql.*;
+import java.sql.Connection;
+import java.sql.PreparedStatement;
+import java.sql.SQLException;
+
 import java.util.NoSuchElementException;
 
-import org.apache.commons.pool.*;
+import org.apache.commons.pool.KeyedObjectPool;
+import org.apache.commons.pool.KeyedPoolableObjectFactory;
+
+
+//import org.apache.commons.pool.*;
 
 /**
  * A {@link DelegatingConnection} that pools {@link PreparedStatement}s.

Modified: jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java?rev=385244&r1=385243&r2=385244&view=diff
==============================================================================
--- jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java (original)
+++ jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java Sat Mar 11 20:48:26 2006
@@ -284,7 +284,8 @@
     
     /**
      * Bugzilla Bug 29832: Broken behaviour for BasicDataSource.setMaxActive(0)
-     * MaxActive == 0 should throw SQLException on getConnection
+     * MaxActive == 0 should throw SQLException on getConnection.
+     * Results from Bug 29863 in commons-pool.
      */
     public void testMaxActiveZero() throws Exception {
         ds.setMaxActive(0);



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org