You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2022/03/03 04:52:00 UTC
[jira] [Commented] (SOLR-14401) "distrib" request handler metrics should only be tracked on pertinent handlers
[ https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500497#comment-17500497 ]
David Smiley commented on SOLR-14401:
-------------------------------------
There are ripple effects of this on our default prometheus exporter config & the grafana dashboard config.
IMO the prometheus config should be simplified -- don't refer to local/distrib/shard at all -- _just expose the data as it is_. The former metrics that specified ".distrib." specifically can simply omit this because it's gone obviously but moreover the handler metric that doesn't have "[shard]" has the same semantics. The ".local." based metrics don't need to be specified as additional metrics because they are already reflected if we just expose all the handler metrics as they are (with "[shard]" suffixes when applicable). Ultimately this means a more simple / direct config.
Downstream (Grafana) can/should filter to what is needed. If it wants what it calls the "*Distributed* blah-blah-blah" then it can filter out the "[shard]" handlers in its expression.
> "distrib" request handler metrics should only be tracked on pertinent handlers
> ------------------------------------------------------------------------------
>
> Key: SOLR-14401
> URL: https://issues.apache.org/jira/browse/SOLR-14401
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: 9.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> SOLR-13979 in 8.4 added separate request handler metrics for distributed requests. However this was done for _all_ request handlers, even though it's mainly SearchHandler (and maybe one or two others?) where a distributed request is even possible. I refer to this as "metrics pollution" and it's a bad thing. It's more weight per handler (latency load & memory), more weight for Solr metrics responses, and it's also _suggestive_ that all registered handlers can have distributed requests when this is quite false, thus confusing people.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org