You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/15 15:11:44 UTC
[PR] [Studio] fix: preserve user topics that resemble system names [rocketmq-dashboard]
yyqdbngt opened a new pull request, #2245:
URL: https://github.com/apache/rocketmq-dashboard/pull/2245
## Summary
- delegate Apache system-topic classification to RocketMQ's canonical `TopicValidator`
- preserve retry, dead-letter, and exact live-broker topic filtering
- keep valid user topics whose names only resemble historical system prefixes
- add regression coverage for canonical and lookalike names
## Problem
The shared filter classified several broad prefixes as system topics. Names such as `CID_orders`, `broker_events`, and `BenchmarkTestOrders` are valid ordinary topics according to current RocketMQ rules, but Studio removed them from topic lists and dashboard totals.
## Verification
- `mvn -Dtest=SystemTopicFilterTest,RocketMQDashboardProviderTest,RocketMQMetadataProviderTest test` (37 tests passed)
- `mvn checkstyle:check` (0 violations)
- `git diff --check`
Closes #2244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Studio] fix: preserve user topics that resemble system names [rocketmq-dashboard]
Posted by "yyqdbngt (via GitHub)" <gi...@apache.org>.
yyqdbngt commented on PR #2245:
URL: https://github.com/apache/rocketmq-dashboard/pull/2245#issuecomment-5329690569
Consolidated into #2362 as requested, rebased onto the latest `rocketmq-studio`, with the current schema/instance refactors accounted for and the combined test suite verified. Closing this individual submission so content review can continue on the consolidated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Studio] fix: preserve user topics that resemble system names [rocketmq-dashboard]
Posted by "yyqdbngt (via GitHub)" <gi...@apache.org>.
yyqdbngt closed pull request #2245: [Studio] fix: preserve user topics that resemble system names
URL: https://github.com/apache/rocketmq-dashboard/pull/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org