You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhiwei Chen <zh...@gmail.com> on 2016/04/04 13:40:25 UTC

Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45528/
-----------------------------------------------------------

(Updated April 4, 2016, 7:40 p.m.)


Review request for mesos, Greg Mann and Vinod Kone.


Summary (updated)
-----------------

Upgrade http-parser to v2.6.2 [mesos].


Bugs: MESOS-5069
    https://issues.apache.org/jira/browse/MESOS-5069


Repository: mesos


Description
-------

Upgrade http-parser to v2.6.2 [mesos].


Diffs (updated)
-----

  3rdparty/cmake/Versions.cmake 35d7e98e9de7dcebbba3b7cdf4d139c918b6f6de 
  LICENSE 1c0355c1462654e1c30546b448f503cd6365dc46 

Diff: https://reviews.apache.org/r/45528/diff/


Testing
-------

../configure --enable-libevent --enable-ssl

sudo make dist check


Thanks,

Zhiwei Chen


Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45528/#review126893
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 4, 2016, 11:40 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45528/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 11:40 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5069
>     https://issues.apache.org/jira/browse/MESOS-5069
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade http-parser to v2.6.2 [mesos].
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake 35d7e98e9de7dcebbba3b7cdf4d139c918b6f6de 
>   LICENSE 1c0355c1462654e1c30546b448f503cd6365dc46 
> 
> Diff: https://reviews.apache.org/r/45528/diff/
> 
> 
> Testing
> -------
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45528/#review126825
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45527, 45528]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 11:40 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45528/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 11:40 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5069
>     https://issues.apache.org/jira/browse/MESOS-5069
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade http-parser to v2.6.2 [mesos].
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake 35d7e98e9de7dcebbba3b7cdf4d139c918b6f6de 
>   LICENSE 1c0355c1462654e1c30546b448f503cd6365dc46 
> 
> Diff: https://reviews.apache.org/r/45528/diff/
> 
> 
> Testing
> -------
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>