You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/23 06:59:37 UTC
[GitHub] [camel] jam01 opened a new pull request #4914: implement logging mdc support CAMEL-12879
jam01 opened a new pull request #4914:
URL: https://github.com/apache/camel/pull/4914
Adds traceId and spanId string methods to SpanAdapter
Adds and replaces MDC fields when activating, deactivating a span
Bumps opentracing to 0.33.0
Note, there was a warning in the parent pom
```
cannot upgrade opentracing until https://github.com/eclipse/microprofile-opentracing v2 is released
```
microprofile-opentracing v2 was released about a month ago, however I could not find the dependencies to that artifact, so I'm not sure if there's anything else that needs to be changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-772594967
You are surely welcome to keep rebasing this to keep track with master.
The MP upgrade is scheduled for Camel 3.9 so hopefully not to long time. Also if we get vertx 4 upgrade, and other big upgrades all together for that release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-821111216
After we have upgraded to MP v4 then you are welcome to work on a new PR agains the master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-766094922
No at upstream Camel then the LTS releases are "locked" we dont do new features etc. But what you build as custom 3rd party components is of course possible.
But this change can only land in master for new releases such as 3.8, 3.9 and in the next LTS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus closed pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus closed pull request #4914:
URL: https://github.com/apache/camel/pull/4914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-841079635
We have upgraded to MP4 on main branch and to be in the 3.10 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-856513850
Closing inative PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-821110814
There is a PR about MP v4 upgrade so this wont be too long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-765894085
This has to be against master, 3.7 is only for patch releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus edited a comment on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
davsclaus edited a comment on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-821110814
There is a PR about MP v4 upgrade so this wont be too long
https://github.com/apache/camel/pull/5390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jam01 commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
jam01 commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-766093472
Oh that's right! 🙈 We needed this MDC integration in order to correlate logs and traces in our backend. We were hoping to continue to use the LTS release as a base for our customers. Is it ok if we repackage camel-tracing and camel-opentracing under a different groupid for now? Maybe once this is added to 3.8 it is still compatible and we only bump those two dependencies in our customer's projects.
Unfortunately I don't know much (read anything) about microprofile. I can still point this to master if you'd like?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jam01 commented on pull request #4914: implement logging mdc support CAMEL-12879
Posted by GitBox <gi...@apache.org>.
jam01 commented on pull request #4914:
URL: https://github.com/apache/camel/pull/4914#issuecomment-766164363
Understood. As for the PR I can close and re-open one that's rebased on master, or should I just close it until CAMEL-16028 regarding microprofile is addressed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org