[GitHub] [lucene] gsmiller commented on a change in pull request #217: LUCENE-10030: [DrillSidewaysScorer.doQueryFirstScoring] disable scoring for near-miss hits

[GitBox <gi...@apache.org>]

gsmiller commented on a change in pull request #217:
URL: https://github.com/apache/lucene/pull/217#discussion_r673515186



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java
##########
@@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits acceptDocs, LeafCollector collector, DocsA
 
       collectDocID = docID;

Review comment:
       What about also updating `collectDocID` in the same place (i.e., inside the `if (failedCollector == null)` check) so that the instance of `ScoreAndDoc` we make available to the various Collectors stays consistent (i.e., the result of calling `score()` always reports the score for the doc returned by `docID()`)? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org