You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Herve Boutemy (JIRA)" <ji...@codehaus.org> on 2009/09/07 12:50:31 UTC
[jira] Moved: (MSHARED-130) [PATCH] quote handling in
linkPatternedText seems broken
[ http://jira.codehaus.org/browse/MSHARED-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy moved MNG-2855 to MSHARED-130:
--------------------------------------------
Affects Version/s: (was: 2.0.5)
maven-reporting-impl 2.0.4.1
Component/s: (was: Multiple Language Support)
(was: Sites & Reporting)
maven-reporting-impl
Complexity: (was: Intermediate)
Key: MSHARED-130 (was: MNG-2855)
Project: Maven Shared Components (was: Maven 2)
> [PATCH] quote handling in linkPatternedText seems broken
> --------------------------------------------------------
>
> Key: MSHARED-130
> URL: http://jira.codehaus.org/browse/MSHARED-130
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-reporting-impl
> Affects Versions: maven-reporting-impl 2.0.4.1
> Reporter: Herve Boutemy
> Fix For: maven-reporting-impl 2.0.4.2
>
> Attachments: AbstractMavenReportRendererTest.java, maven-reporting-impl-quote.patch, maven-reporting-impl-quote2.patch
>
>
> MPIR-59 shows a problem on a quote for french translation : an easy workaround is to double the quote '', but these 2 quotes are rendered in the final report, which is not what is expected.
> Then I checked the correponding code, and found inconsistencies in the way quotes are handled (apparently to protect braces from being interpreted).
> I wrote a JUnit test to show these inconsistencies (which in addition showed some bugs on special situations).
> To get consistent results, I think that single quotes should be removed when found: that's what is done in the patch.
> But doing so, there will be problems with existing texts that contain only one single quote: what used to work won't work any more, because the quote should be doubled (and not let without a closing quote).
> Should this patch be applied or not ? I really don't know: without it, you can have weird results (showed in the JUnit test). But when applying it, prepare yourself to some problems with existing texts: I can't say how much content it will break...
> At least, adding the JUnit test to the codebase will help to deal with the current situation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira