You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/23 16:33:28 UTC

[GitHub] [spark] srowen commented on pull request #37967: Scalable SkipGram-Word2Vec implementation

srowen commented on PR #37967:
URL: https://github.com/apache/spark/pull/37967#issuecomment-1288150047

   The macro issue here is that we have an implementation in MLlib, and aren't really adding more to it. This is a whole new implementation to maintain. (Minor: it adds the fastuil dependency which we had problems with in the past, but that's not a big deal; see also https://spark.apache.org/contributing.html)
   
   I don't think we would add more here, but would consider changes to the existing impl. Or this can be just released as a separate repo/library.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org