You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Simon Laws (JIRA)" <tu...@ws.apache.org> on 2007/11/23 11:40:43 UTC

[jira] Created: (TUSCANY-1919) Operations with void return types not being correctly marked as wrapped in some circumstances.

Operations with void return types not being correctly marked as wrapped in some circumstances. 
-----------------------------------------------------------------------------------------------

                 Key: TUSCANY-1919
                 URL: https://issues.apache.org/jira/browse/TUSCANY-1919
             Project: Tuscany
          Issue Type: Bug
    Affects Versions: Java-SCA-1.0
         Environment: All
            Reporter: Simon Laws
            Assignee: Simon Laws
             Fix For: Java-SCA-1.1


In some circumstances (which I haven't got to the bottom of) operations of the form:

public void registerNode(String nodeURI, String nodeURL) throws DomainException;

The reason this is happening is that the test for wrapperedness in WSOperationIntrospectionImpl

            wrapperStyle =
                (operation.getInput().getMessage().getParts().values().size() == 0 || wrapper.getInputChildElements() != null) && (operation
                    .getOutput() == null || wrapper.getOutputChildElements() != null);

Returns false because operation.getOutput() is non null but there are no parts in the operation. Looking at this test it is not as symterical as you would expect however it is still the case that operation.getOutput() return null so the test would have to be changed to something like:

            wrapperStyle =
                (operation.getInput() == null || operation.getInput().getMessage().getParts().size() == 0 || wrapper.getInputChildElements() != null) && 
                (operation.getOutput() == null || operation.getOutput().getMessage().getParts().size() == 0 || wrapper.getOutputChildElements() != null);

Which looks right given the JAX-WS rules, solves my problem and gives a clean build. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Resolved: (TUSCANY-1919) Operations with void return types not being correctly marked as wrapped in some circumstances.

Posted by "Simon Laws (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws resolved TUSCANY-1919.
---------------------------------

    Resolution: Fixed

Fix checked in as described

> Operations with void return types not being correctly marked as wrapped in some circumstances. 
> -----------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-1919
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1919
>             Project: Tuscany
>          Issue Type: Bug
>    Affects Versions: Java-SCA-1.0
>         Environment: All
>            Reporter: Simon Laws
>            Assignee: Simon Laws
>             Fix For: Java-SCA-1.1
>
>
> In some circumstances (which I haven't got to the bottom of) operations of the form:
> public void registerNode(String nodeURI, String nodeURL) throws DomainException;
> The reason this is happening is that the test for wrapperedness in WSOperationIntrospectionImpl
>             wrapperStyle =
>                 (operation.getInput().getMessage().getParts().values().size() == 0 || wrapper.getInputChildElements() != null) && (operation
>                     .getOutput() == null || wrapper.getOutputChildElements() != null);
> Returns false because operation.getOutput() is non null but there are no parts in the operation. Looking at this test it is not as symterical as you would expect however it is still the case that operation.getOutput() return null so the test would have to be changed to something like:
>             wrapperStyle =
>                 (operation.getInput() == null || operation.getInput().getMessage().getParts().size() == 0 || wrapper.getInputChildElements() != null) && 
>                 (operation.getOutput() == null || operation.getOutput().getMessage().getParts().size() == 0 || wrapper.getOutputChildElements() != null);
> Which looks right given the JAX-WS rules, solves my problem and gives a clean build. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org