You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/05 20:55:18 UTC
[GitHub] [airflow] pingzh opened a new pull request, #22764: No need to load whole ti in current_state
pingzh opened a new pull request, #22764:
URL: https://github.com/apache/airflow/pull/22764
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
since it only needs the `state` column.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on a diff in pull request #22764: No need to load whole ti in current_state
Posted by GitBox <gi...@apache.org>.
pingzh commented on code in PR #22764:
URL: https://github.com/apache/airflow/pull/22764#discussion_r844158290
##########
airflow/models/taskinstance.py:
##########
@@ -723,20 +723,16 @@ def current_state(self, session=NEW_SESSION) -> str:
:param session: SQLAlchemy ORM Session
"""
- ti = (
- session.query(TaskInstance)
+ state = (
+ session.query(TaskInstance.state)
.filter(
TaskInstance.dag_id == self.dag_id,
TaskInstance.task_id == self.task_id,
TaskInstance.run_id == self.run_id,
)
- .all()
+ .one_or_none()
)
- if ti:
- state = ti[0].state
- else:
- state = None
- return state
+ return state[0]
Review Comment:
nice, thanks. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22764: No need to load whole ti in current_state
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22764:
URL: https://github.com/apache/airflow/pull/22764#issuecomment-1089497512
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #22764: No need to load whole ti in current_state
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #22764:
URL: https://github.com/apache/airflow/pull/22764#discussion_r843389686
##########
airflow/models/taskinstance.py:
##########
@@ -723,20 +723,16 @@ def current_state(self, session=NEW_SESSION) -> str:
:param session: SQLAlchemy ORM Session
"""
- ti = (
- session.query(TaskInstance)
+ state = (
Review Comment:
```suggestion
return (
```
I think this would work, and is even simpler? (Sorry, has to be across 3 suggestions 🤷♂️)
##########
airflow/models/taskinstance.py:
##########
@@ -723,20 +723,16 @@ def current_state(self, session=NEW_SESSION) -> str:
:param session: SQLAlchemy ORM Session
"""
- ti = (
- session.query(TaskInstance)
+ state = (
+ session.query(TaskInstance.state)
.filter(
TaskInstance.dag_id == self.dag_id,
TaskInstance.task_id == self.task_id,
TaskInstance.run_id == self.run_id,
)
- .all()
+ .one_or_none()
Review Comment:
```suggestion
.scalar()
```
##########
airflow/models/taskinstance.py:
##########
@@ -723,20 +723,16 @@ def current_state(self, session=NEW_SESSION) -> str:
:param session: SQLAlchemy ORM Session
"""
- ti = (
- session.query(TaskInstance)
+ state = (
+ session.query(TaskInstance.state)
.filter(
TaskInstance.dag_id == self.dag_id,
TaskInstance.task_id == self.task_id,
TaskInstance.run_id == self.run_id,
)
- .all()
+ .one_or_none()
)
- if ti:
- state = ti[0].state
- else:
- state = None
- return state
+ return state[0]
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #22764: No need to load whole ti in current_state
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #22764:
URL: https://github.com/apache/airflow/pull/22764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org