[GitHub] XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY

[GitBox <gi...@apache.org>]

XD-DENG edited a comment on issue #3738: [AIRFLOW-2886] Secure Flask SECRET_KEY
URL: https://github.com/apache/incubator-airflow/pull/3738#issuecomment-412227570
 
 
   Hi @feng-tao , in cluster mode, given the `.cfg` files are initiated on different nodes, the SECRET_KEY will be different. That's also why Craig mentioned it fixes now on a single webserver instance (multiple workers), but doesn't work on a cluster of webservers ([LINK](https://issues.apache.org/jira/browse/AIRFLOW-2866?focusedCommentId=16576717&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16576717)).
   
   I insist in that we should have random SECRET_KEY for the webserver. If we use the previous way, that is to have a default value in the template, it's gonna be risky.
   
   If users want to use a cluster of webservers, they need to either 
   - make sure that SECRET_KEYs are consistent across nodes (to manually specify)
   or
   - apply `ip-hash` strategy for the cluster load-balancing, rather than `round-robin`.
   
   Please let me know your thoughts?
   
   cc: @Fokko @kaxil 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services