Re: [jira] Updated: (JAMES-530) Add more spool manage commands to RemoteManager

[Norman Maurer <nm...@byteaction.de>]

Am Freitag, den 16.06.2006, 15:12 +0200 schrieb Bernd Fondermann:
> Hi Norman,
> 
> Making James more manageble at runtime is really appreciated. I am
> planing to extend the JMX counterparts to RemoteManager soon.
> 
> That's also why I propose to move all the 'business logic' out of the
> RemoteManHandler into some spooling utility class. This would allow
> for other management interfaces (e.g. JMX) to reuse the logic.
> 
> Maybe I am overly critical, but I really dislike the copy-pastes of
> larger chunks of code. Makes it so much harder to read the patch and
> maintain the code.

I knew before that you write this ;-)

> More general note concerning the help syntax: I'm used to reading
> arguments enclosed in [ ] as being optional. Maybe we should change
> them into < > and apply the [ ] where arguments are optional?
> 
>   Bernd

This was why i not commit it and only post to jira. I will not commit it
until i make it a bit cleaner.. Just want to knew what you other guys
think about it and the way it work ;-)

bye
Norman
 

Re: [jira] Updated: (JAMES-530) Add more spool manage commands to RemoteManager

[Bernd Fondermann <be...@googlemail.com>]

On 6/16/06, Norman Maurer <nm...@byteaction.de> wrote:
> Am Freitag, den 16.06.2006, 15:12 +0200 schrieb Bernd Fondermann:
> > Maybe I am overly critical, but I really dislike the copy-pastes of
> > larger chunks of code. Makes it so much harder to read the patch and
> > maintain the code.
>
> I knew before that you write this ;-)

:-) ok, I'll try something new next time ;-)

> > More general note concerning the help syntax: I'm used to reading
> > arguments enclosed in [ ] as being optional. Maybe we should change
> > them into < > and apply the [ ] where arguments are optional?
> >
> >   Bernd
>
> This was why i not commit it and only post to jira. I will not commit it
> until i make it a bit cleaner.. Just want to knew what you other guys
> think about it and the way it work ;-)

ok, cool.
reading a cleaner patch would not have taken me 2 days... just kidding ;-)

  Bernd

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org