[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

[GitBox <gi...@apache.org>]

darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator
URL: https://github.com/apache/airflow/pull/5900#discussion_r317643828
 
 

 ##########
 File path: airflow/contrib/operators/awsbatch_operator.py
 ##########
 @@ -110,10 +115,17 @@ def execute(self, context):
         )
 
         try:
+            if 'memory' in self.overrides:
+                self.overrides['memory'] = int(self.overrides['memory'])
+
+            if 'vcpus' in self.overrides:
+                self.overrides['vcpus'] = int(self.overrides['vcpus'])
+
             response = self.client.submit_job(
                 jobName=self.job_name,
                 jobQueue=self.job_queue,
                 jobDefinition=self.job_definition,
+                parameters=self.parameters,
                 containerOverrides=self.overrides)
 
 Review comment:
   - nit: the PR could focus only on the addition of params (remove any manipulation of overrides)
   - nit: leave the responsibility for parsing job-submit options (types) to the client (+1 @milton0825)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services