You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/14 16:09:42 UTC
[GitHub] [airflow] bbovenzi opened a new pull request #15852: Fix modal import in graph.js
bbovenzi opened a new pull request #15852:
URL: https://github.com/apache/airflow/pull/15852
Modals weren't opening in Graph View. `call_modal` no longer existed. Switching to import `callModal` instead.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #15852: Fix modal import in graph.js
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #15852:
URL: https://github.com/apache/airflow/pull/15852#issuecomment-841357675
@ashb Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mrbaguvix commented on a change in pull request #15852: Fix modal import in graph.js
Posted by GitBox <gi...@apache.org>.
mrbaguvix commented on a change in pull request #15852:
URL: https://github.com/apache/airflow/pull/15852#discussion_r632651990
##########
File path: airflow/www/static/js/graph.js
##########
@@ -155,8 +156,8 @@ function draw() {
if (nodeId in taskInstances) tryNumber = taskInstances[nodeId].tryNumber;
else tryNumber = 0;
- if (task.task_type === 'SubDagOperator') call_modal(nodeId, executionDate, task.extra_links, tryNumber, true);
- else call_modal(nodeId, executionDate, task.extra_links, tryNumber, undefined);
+ if (task.task_type === 'SubDagOperator') callModal(nodeId, executionDate, task.extra_links, tryNumber, true);
+ else callModal(nodeId, executionDate, task.extra_links, tryNumber, undefined);
} else {
// join node between TaskGroup. Ignore.
}
Review comment:
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #15852: Fix modal import in graph.js
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #15852:
URL: https://github.com/apache/airflow/pull/15852#issuecomment-841353256
This is needed for 2.1 right @bbovenzi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #15852: Fix modal import in graph.js
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #15852:
URL: https://github.com/apache/airflow/pull/15852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mrbaguvix commented on a change in pull request #15852: Fix modal import in graph.js
Posted by GitBox <gi...@apache.org>.
mrbaguvix commented on a change in pull request #15852:
URL: https://github.com/apache/airflow/pull/15852#discussion_r632651990
##########
File path: airflow/www/static/js/graph.js
##########
@@ -155,8 +156,8 @@ function draw() {
if (nodeId in taskInstances) tryNumber = taskInstances[nodeId].tryNumber;
else tryNumber = 0;
- if (task.task_type === 'SubDagOperator') call_modal(nodeId, executionDate, task.extra_links, tryNumber, true);
- else call_modal(nodeId, executionDate, task.extra_links, tryNumber, undefined);
+ if (task.task_type === 'SubDagOperator') callModal(nodeId, executionDate, task.extra_links, tryNumber, true);
+ else callModal(nodeId, executionDate, task.extra_links, tryNumber, undefined);
} else {
// join node between TaskGroup. Ignore.
}
Review comment:
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #15852: Fix modal import in graph.js
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #15852:
URL: https://github.com/apache/airflow/pull/15852#discussion_r632652920
##########
File path: airflow/www/static/js/graph.js
##########
@@ -155,8 +156,8 @@ function draw() {
if (nodeId in taskInstances) tryNumber = taskInstances[nodeId].tryNumber;
else tryNumber = 0;
- if (task.task_type === 'SubDagOperator') call_modal(nodeId, executionDate, task.extra_links, tryNumber, true);
- else call_modal(nodeId, executionDate, task.extra_links, tryNumber, undefined);
+ if (task.task_type === 'SubDagOperator') callModal(nodeId, executionDate, task.extra_links, tryNumber, true);
+ else callModal(nodeId, executionDate, task.extra_links, tryNumber, undefined);
} else {
// join node between TaskGroup. Ignore.
}
Review comment:
Yes, but this wasn't changed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org