You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by da...@apache.org on 2023/11/22 16:15:29 UTC
(beam) branch master updated: Improve actionability on IT errors (with Dataflow job URL) (#29520)
This is an automated email from the ASF dual-hosted git repository.
damccorm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new e863d919a32 Improve actionability on IT errors (with Dataflow job URL) (#29520)
e863d919a32 is described below
commit e863d919a32bbcdb04ad35fd1697d94f0bdac3dd
Author: Bruno Volpato <bv...@google.com>
AuthorDate: Wed Nov 22 16:15:22 2023 +0000
Improve actionability on IT errors (with Dataflow job URL) (#29520)
---
.../src/main/java/org/apache/beam/it/conditions/ConditionCheck.java | 2 +-
.../org/apache/beam/it/gcp/dataflow/AbstractPipelineLauncher.java | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/it/conditions/src/main/java/org/apache/beam/it/conditions/ConditionCheck.java b/it/conditions/src/main/java/org/apache/beam/it/conditions/ConditionCheck.java
index de1b2b0cf2b..17840178ef7 100644
--- a/it/conditions/src/main/java/org/apache/beam/it/conditions/ConditionCheck.java
+++ b/it/conditions/src/main/java/org/apache/beam/it/conditions/ConditionCheck.java
@@ -42,7 +42,7 @@ public abstract class ConditionCheck implements Supplier<Boolean> {
CheckResult result = check();
if (!result.success) {
- LOG.info("[✗] Condition '{}' failed! {}", getDescription(), result.message);
+ LOG.info("[✗] Condition '{}' not met! {}", getDescription(), result.message);
return false;
}
diff --git a/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/dataflow/AbstractPipelineLauncher.java b/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/dataflow/AbstractPipelineLauncher.java
index b5c9535953b..b3bb29b960b 100644
--- a/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/dataflow/AbstractPipelineLauncher.java
+++ b/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/dataflow/AbstractPipelineLauncher.java
@@ -307,8 +307,9 @@ public abstract class AbstractPipelineLauncher implements PipelineLauncher {
throw new RuntimeException(
String.format(
"The job failed before launch! For more "
- + "information please check if the job log for Job ID: %s, under project %s.",
- jobId, project));
+ + "information please check the job log at "
+ + "https://console.cloud.google.com/dataflow/jobs/%s/%s?project=%s.",
+ region, jobId, project));
}
return state;
}