You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ha...@apache.org on 2018/12/23 08:10:44 UTC
[royale-asjs] branch develop updated: This should be assignment
instead of comparison
This is an automated email from the ASF dual-hosted git repository.
harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new a0af3d9 This should be assignment instead of comparison
a0af3d9 is described below
commit a0af3d9fb1c9dae89ebf7cc7145be57a97d5ab0b
Author: Harbs <ha...@in-tools.com>
AuthorDate: Sun Dec 23 10:10:35 2018 +0200
This should be assignment instead of comparison
---
examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml b/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
index c4b6a25..e5f96c8 100644
--- a/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
+++ b/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
@@ -117,7 +117,7 @@ limitations under the License.
var c:int = hash.indexOf(delimiter);
if (c == -1)
{
- c == hash.indexOf("$");
+ c = hash.indexOf("$");
if (c != -1)
delimiter = "$";
}
Re: [royale-asjs] branch develop updated: This should be assignment
instead of comparison
Posted by Harbs <ha...@gmail.com>.
FWIW, I have not actually tested this, but the code made no sense as it was. I noticed this because of a warning in the Closure Compiler.
> On Dec 23, 2018, at 10:10 AM, harbs@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> harbs pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new a0af3d9 This should be assignment instead of comparison
> a0af3d9 is described below
>
> commit a0af3d9fb1c9dae89ebf7cc7145be57a97d5ab0b
> Author: Harbs <ha...@in-tools.com>
> AuthorDate: Sun Dec 23 10:10:35 2018 +0200
>
> This should be assignment instead of comparison
> ---
> examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml b/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
> index c4b6a25..e5f96c8 100644
> --- a/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
> +++ b/examples/royale/ASDoc/src/main/royale/ASDocMainView.mxml
> @@ -117,7 +117,7 @@ limitations under the License.
> var c:int = hash.indexOf(delimiter);
> if (c == -1)
> {
> - c == hash.indexOf("$");
> + c = hash.indexOf("$");
> if (c != -1)
> delimiter = "$";
> }
>