(maven-gh-actions-shared) branch v5 updated: Skip license check for committers with private org membership

[gn...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch v5
in repository https://gitbox.apache.org/repos/asf/maven-gh-actions-shared.git


The following commit(s) were added to refs/heads/v5 by this push:
     new 70687eb  Skip license check for committers with private org membership
70687eb is described below

commit 70687ebe69d6d9bd11e457d287a8f7c2aaf97059
Author: Guillaume Nodet <gn...@gmail.com>
AuthorDate: Sun Oct 4 19:08:50 2026 +0000

    Skip license check for committers with private org membership
    
    Apache committers whose GitHub org membership is private show up with
    author_association=COLLABORATOR (not MEMBER) in the pull_request event.
    The previous check only skipped OWNER and MEMBER, causing the license
    declaration check to fire for committers unnecessarily.
    
    Add COLLABORATOR to the skip list to fix this.
---
 .github/workflows/pr-check.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
index 6455bf3..ea720e8 100644
--- a/.github/workflows/pr-check.yml
+++ b/.github/workflows/pr-check.yml
@@ -37,10 +37,13 @@ jobs:
     runs-on: ubuntu-slim
     # Skip (a skipped job counts as successful, so a required check doesn't block the merge):
     # - PRs opened by bots (Dependabot, Renovate, other GitHub Apps),
-    # - PRs opened by members of the organization owning the repository (apache).
+    # - PRs opened by members/committers of the organization owning the repository (apache).
+    #   MEMBER       = org member with public membership (PMC member)
+    #   OWNER        = org owner
+    #   COLLABORATOR = committer whose org membership is private (covers most Apache committers)
     if: >-
       github.event.pull_request.user.type != 'Bot' &&
-      !contains(fromJSON('["OWNER", "MEMBER"]'), github.event.pull_request.author_association)
+      !contains(fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.pull_request.author_association)
     # Prevents races (e.g. opened + edited in quick succession => two comments).
     # Do NOT define the same concurrency group in the caller – it would deadlock.
     concurrency: