You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/01/05 02:22:54 UTC
[jira] Created: (DBCP-314) Hidden fields can cause problems when
code is updated
Hidden fields can cause problems when code is updated
-----------------------------------------------------
Key: DBCP-314
URL: https://issues.apache.org/jira/browse/DBCP-314
Project: Commons Dbcp
Issue Type: Bug
Reporter: Sebb
Priority: Minor
There are quite a few instances of fields that are hidden (masked) by local variables or parameters.
This is a potential source of bugs, as the hidden field can be accidentally revealed and used when code is updated.
The classes that currently contain such code are:
LocalXAConnectionFactory - 6 instances
InstanceKeyDataSource
DriverAdapterCPDS
PoolingDataSource
BasicDataSource - 2 instances
AbandonedTrace - 2 instances
BasicDataSource
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DBCP-314) Hidden fields can cause problems when
code is updated
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved DBCP-314.
-----------------------
Resolution: Fixed
URL: http://svn.apache.org/viewvc?rev=895844&view=rev
Log:
DBCP-314 Renamed variables with duplicate names in different scopes.
> Hidden fields can cause problems when code is updated
> -----------------------------------------------------
>
> Key: DBCP-314
> URL: https://issues.apache.org/jira/browse/DBCP-314
> Project: Commons Dbcp
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
>
> There are quite a few instances of fields that are hidden (masked) by local variables or parameters.
> This is a potential source of bugs, as the hidden field can be accidentally revealed and used when code is updated.
> The classes that currently contain such code are:
> LocalXAConnectionFactory - 6 instances
> InstanceKeyDataSource
> DriverAdapterCPDS
> PoolingDataSource
> BasicDataSource - 2 instances
> AbandonedTrace - 2 instances
> BasicDataSource
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DBCP-314) Hidden fields can cause problems when
code is updated
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz closed DBCP-314.
----------------------------
> Hidden fields can cause problems when code is updated
> -----------------------------------------------------
>
> Key: DBCP-314
> URL: https://issues.apache.org/jira/browse/DBCP-314
> Project: Commons Dbcp
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
>
> There are quite a few instances of fields that are hidden (masked) by local variables or parameters.
> This is a potential source of bugs, as the hidden field can be accidentally revealed and used when code is updated.
> The classes that currently contain such code are:
> LocalXAConnectionFactory - 6 instances
> InstanceKeyDataSource
> DriverAdapterCPDS
> PoolingDataSource
> BasicDataSource - 2 instances
> AbandonedTrace - 2 instances
> BasicDataSource
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.