You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2012/05/27 00:01:29 UTC

svn commit: r1342977 - /maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java

Author: hboutemy
Date: Sat May 26 22:01:29 2012
New Revision: 1342977

URL: http://svn.apache.org/viewvc?rev=1342977&view=rev
Log:
don't show readonly parameters in help

Modified:
    maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java

Modified: maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java?rev=1342977&r1=1342976&r2=1342977&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java Sat May 26 22:01:29 2012
@@ -157,9 +157,12 @@ public class PluginDescriptorGenerator
 
             GeneratorUtils.element( w, "goalPrefix", pluginDescriptor.getGoalPrefix() );
 
-            GeneratorUtils.element( w, "isolatedRealm", String.valueOf( pluginDescriptor.isIsolatedRealm() ) );
+            if ( !helpDescriptor )
+            {
+                GeneratorUtils.element( w, "isolatedRealm", String.valueOf( pluginDescriptor.isIsolatedRealm() ) );
 
-            GeneratorUtils.element( w, "inheritedByDefault", String.valueOf( pluginDescriptor.isInheritedByDefault() ) );
+                GeneratorUtils.element( w, "inheritedByDefault", String.valueOf( pluginDescriptor.isInheritedByDefault() ) );
+            }
 
             w.startElement( "mojos" );
 
@@ -174,7 +177,10 @@ public class PluginDescriptorGenerator
 
             w.endElement();
 
-            GeneratorUtils.writeDependencies( w, pluginDescriptor );
+            if ( !helpDescriptor )
+            {
+                GeneratorUtils.writeDependencies( w, pluginDescriptor );
+            }
 
             w.endElement();
 
@@ -434,7 +440,7 @@ public class PluginDescriptorGenerator
                 {
                     requirements.put( parameter.getName(), parameter.getRequirement() );
                 }
-                else
+                else if ( !helpDescriptor || parameter.isEditable() ) // don't show readonly parameters in help
                 {
                     // treat it as a normal parameter.
 
@@ -496,6 +502,12 @@ public class PluginDescriptorGenerator
 
             for ( Parameter parameter : configuration )
             {
+                if ( helpDescriptor && !parameter.isEditable() )
+                {
+                    // don't show readonly parameters in help
+                    continue;
+                }
+
                 w.startElement( parameter.getName() );
 
                 String type = parameter.getType();
@@ -524,7 +536,7 @@ public class PluginDescriptorGenerator
         // Requirements
         // ----------------------------------------------------------------------
 
-        if ( !requirements.isEmpty() )
+        if ( !requirements.isEmpty() && !helpDescriptor )
         {
             w.startElement( "requirements" );