You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/12/09 21:47:38 UTC
Review Request 54611: Windows: Added `recordio_tests.cpp` to Agent
build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54611/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Bugs: MESOS-6701
https://issues.apache.org/jira/browse/MESOS-6701
Repository: mesos
Description
-------
This commit will resolve MESOS-6701. In particular, we resolve the
namespace resolution errors that prevent `recordio_tests.cpp` from
building with MSVC > 1900, and add the file to the Agent tests build.
Diffs
-----
src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75
src/tests/common/recordio_tests.cpp 63e284acced8ab0d3528e518ddf0a06c9cfa9777
Diff: https://reviews.apache.org/r/54611/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 54611: Windows: Added `recordio_tests.cpp` to
Agent build.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54611/#review159365
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Dec. 9, 2016, 5:29 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54611/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 5:29 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6701
> https://issues.apache.org/jira/browse/MESOS-6701
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit will resolve MESOS-6701. In particular, we resolve the
> namespace resolution errors that prevent `recordio_tests.cpp` from
> building with MSVC > 1900, and add the file to the Agent tests build.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75
> src/tests/common/recordio_tests.cpp 63e284acced8ab0d3528e518ddf0a06c9cfa9777
>
> Diff: https://reviews.apache.org/r/54611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 54611: Windows: Added `recordio_tests.cpp` to
Agent build.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54611/
-----------------------------------------------------------
(Updated Dec. 10, 2016, 1:29 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Bugs: MESOS-6701
https://issues.apache.org/jira/browse/MESOS-6701
Repository: mesos
Description
-------
This commit will resolve MESOS-6701. In particular, we resolve the
namespace resolution errors that prevent `recordio_tests.cpp` from
building with MSVC > 1900, and add the file to the Agent tests build.
Diffs
-----
src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75
src/tests/common/recordio_tests.cpp 63e284acced8ab0d3528e518ddf0a06c9cfa9777
Diff: https://reviews.apache.org/r/54611/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 54611: Windows: Added `recordio_tests.cpp` to
Agent build.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54611/
-----------------------------------------------------------
(Updated Dec. 9, 2016, 11:59 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Bugs: MESOS-6701
https://issues.apache.org/jira/browse/MESOS-6701
Repository: mesos
Description
-------
This commit will resolve MESOS-6701. In particular, we resolve the
namespace resolution errors that prevent `recordio_tests.cpp` from
building with MSVC > 1900, and add the file to the Agent tests build.
Diffs (updated)
-----
src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75
src/tests/common/recordio_tests.cpp 63e284acced8ab0d3528e518ddf0a06c9cfa9777
Diff: https://reviews.apache.org/r/54611/diff/
Testing
-------
Thanks,
Alex Clemmer