You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Philip Zeyliger (JIRA)" <ji...@apache.org> on 2009/12/31 19:31:29 UTC
[jira] Created: (AVRO-275) Histogram class to keep RPC timing stats
Histogram class to keep RPC timing stats
----------------------------------------
Key: AVRO-275
URL: https://issues.apache.org/jira/browse/AVRO-275
Project: Avro
Issue Type: New Feature
Components: java
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
Class to keep a histogram of RPC timinigs for AVRO-270.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-275) Histogram class to keep RPC timing stats
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-275:
---------------------------------
Attachment: AVRO-275.patch.txt
Attaching a new patch where the new non-test classes are package-private.
As far as committing AVRO-273, AVRO-275, AVRO-279 together, that would be splendid. They're designed so that this one and AVRO-273 could be done independently (though would have no utility), so that the reviews are easier.
> Histogram class to keep RPC timing stats
> ----------------------------------------
>
> Key: AVRO-275
> URL: https://issues.apache.org/jira/browse/AVRO-275
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-275.patch.txt, AVRO-275.patch.txt
>
>
> Class to keep a histogram of RPC timinigs for AVRO-270.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-275) Histogram class to keep RPC timing stats
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-275:
---------------------------------
Status: Patch Available (was: Open)
> Histogram class to keep RPC timing stats
> ----------------------------------------
>
> Key: AVRO-275
> URL: https://issues.apache.org/jira/browse/AVRO-275
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-275.patch.txt, AVRO-275.patch.txt
>
>
> Class to keep a histogram of RPC timinigs for AVRO-270.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-275) Histogram class to keep RPC timing stats
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated AVRO-275:
---------------------------------
Attachment: AVRO-275.patch.txt
Attaching a patch.
I went for a non-adaptive approach: you have to specify the formula (a "segmenter" implementation: I don't much like the name) by which to bucket your values ahead of time, as well as the number of buckets. I wrote one implementation of this formula (using a TreeMap), and linear and exponential versions make sense too.
This may be more convoluted than necessary: I support generic buckets, not just numbers.
I looked around a bit on whether I should have borrowed other Apache-licensed code. http://code.google.com/p/hist4j/ has an adaptive approach. Apache commons math has summary statistics code.
> Histogram class to keep RPC timing stats
> ----------------------------------------
>
> Key: AVRO-275
> URL: https://issues.apache.org/jira/browse/AVRO-275
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-275.patch.txt
>
>
> Class to keep a histogram of RPC timinigs for AVRO-270.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-275) Histogram class to keep RPC timing
stats
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797780#action_12797780 ]
Doug Cutting commented on AVRO-275:
-----------------------------------
This looks fine, but, again, I don't think this makes much sense in Avro indepdendent of AVRO-270: I'd prefer to commit this, AVRO-273 and AVRO-275 all in a single commit. I also question whether this needs to be public. It's nice to have the timer and the histogram class pluggable, but until someone wants to plug in different implementations, these just increase the number of public APIs we have to maintain back-compatibly. So my vote might be to make these package-private for now.
> Histogram class to keep RPC timing stats
> ----------------------------------------
>
> Key: AVRO-275
> URL: https://issues.apache.org/jira/browse/AVRO-275
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: AVRO-275.patch.txt
>
>
> Class to keep a histogram of RPC timinigs for AVRO-270.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-275) Histogram class to keep RPC timing stats
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-275:
------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Philip!
> Histogram class to keep RPC timing stats
> ----------------------------------------
>
> Key: AVRO-275
> URL: https://issues.apache.org/jira/browse/AVRO-275
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Fix For: 1.3.0
>
> Attachments: AVRO-275.patch.txt, AVRO-275.patch.txt
>
>
> Class to keep a histogram of RPC timinigs for AVRO-270.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.