You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/04 22:09:53 UTC

[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #19796: [v1.x] ONNX export support for multiple input data types

waytrue17 commented on a change in pull request #19796:
URL: https://github.com/apache/incubator-mxnet/pull/19796#discussion_r570578137



##########
File path: python/mxnet/contrib/onnx/mx2onnx/export_model.py
##########
@@ -28,7 +28,7 @@
 from ._export_helper import load_module
 
 
-def export_model(sym, params, input_shape, input_type=np.float32,

Review comment:
       It definitely make sense to preserve the existing behavior. My concern is that, just like `input_shape`, the `input_type` should also be explicitly passed (they need to be consistent with `input_shape`). The customer may forget to pass it and cause some issues if we provide a default value of it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org