[jira] [Commented] (CTAKES-278) UMLS user and password should be validated

["James Joseph Masanz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CTAKES-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855748#comment-13855748 ] 

James Joseph Masanz commented on CTAKES-278:
--------------------------------------------


Hi Chen,

Which version of cTAKES are you seeing this in?

There is code in trunk and in the 3.1.1 branch [1] that at least throws an Exception stating it is Invalid UMLS License:

   throw new Exception("Failed to initilize.  Invalid UMLS License");

[1] http://svn.apache.org/viewvc/ctakes/branches/ctakes-3.1.1/ctakes-dictionary-lookup/src/main/java/org/apache/ctakes/dictionary/lookup/ae/UmlsDictionaryLookupAnnotator.java?revision=1541928&view=markup

-- James



> UMLS user and password should be validated
> ------------------------------------------
>
>                 Key: CTAKES-278
>                 URL: https://issues.apache.org/jira/browse/CTAKES-278
>             Project: cTAKES
>          Issue Type: Improvement
>          Components: ctakes-dictionary-lookup
>    Affects Versions: future enhancement
>            Reporter: Chen Lin
>            Priority: Minor
>
> If the umls user name and password are not set properly, now the dictionary-lookup module will throw NullPointerException, which is not very informative. isValidUMLSUser should validate input and raise an informative exception instead.
> Caused by: java.lang.NullPointerException 
>          at java.net.URLEncoder.encode(URLEncoder.java:188) 
>          at org.apache.ctakes.dictionary.lookup.ae.UmlsDictionaryLookupAnnotator.isValidUMLSUser(UmlsDictionaryLookupAnnotator.java:87) 
>          at org.apache.ctakes.dictionary.lookup.ae.UmlsDictionaryLookupAnnotator.initialize(UmlsDictionaryLookupAnnotator.java:70) 
> Many thanks!



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)