You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devicemap.apache.org by "Werner Keil (JIRA)" <ji...@apache.org> on 2014/07/23 22:42:38 UTC

[jira] [Commented] (DMAP-44) XMLParser is implementation detail

    [ https://issues.apache.org/jira/browse/DMAP-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072299#comment-14072299 ] 

Werner Keil commented on DMAP-44:
---------------------------------

Especially the JSonParser contains only static methods, so it makes an impression of a static helper class at the moment, but ideally somewhat similar to the concept of "Loader" a true parser interface or abstract base class may clarify this concern and the separate packagge...

> XMLParser is implementation detail
> ----------------------------------
>
>                 Key: DMAP-44
>                 URL: https://issues.apache.org/jira/browse/DMAP-44
>             Project: DeviceMap
>          Issue Type: Bug
>          Components: Java API
>            Reporter: Werner Keil
>            Assignee: Reza Naghibi
>            Priority: Minor
>
> The XMLParser class is only an implementation detail behind private code in a single Loader subclass. There is currently no public API that justifies a package for a single class that into the bargain is just a piece of code that was refactored from private class in a single loader class. Should go to loader.impl until it's really used or exposed anywhere.



--
This message was sent by Atlassian JIRA
(v6.2#6252)