You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/12/19 23:34:56 UTC
Re: Review Request 53707: Added a Windows isolator. Removed
`#ifdef`-ed block from Posix.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53707/#review159667
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 199 - 202)
<https://reviews.apache.org/r/53707/#comment230680>
Remove this bit too.
src/slave/containerizer/mesos/isolators/filesystem/windows.cpp (line 87)
<https://reviews.apache.org/r/53707/#comment230681>
(Based on a discussion offline) We should look into why the composing containerizer isn't guarding isolators from Docker tasks.
src/slave/containerizer/mesos/isolators/filesystem/windows.cpp (lines 194 - 210)
<https://reviews.apache.org/r/53707/#comment230682>
Remove this bit. Except perhaps the TODO.
- Joseph Wu
On Nov. 13, 2016, 9:45 p.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53707/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2016, 9:45 p.m.)
>
>
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a Windows isolator. Removed `#ifdef`-ed block from Posix.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 270d2aa6e06f323bfb6eee3b703a24a600a55871
> src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 2bf011d3e7b014a17f759851d755b161c897b131
> src/slave/containerizer/mesos/isolators/filesystem/windows.cpp f169c380f803a2111b1612cee60250ee9a30ef2e
>
> Diff: https://reviews.apache.org/r/53707/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Pravat
>
>