You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2017/12/01 21:28:15 UTC

[GitHub] spark pull request #19527: [SPARK-13030][ML] Create OneHotEncoderEstimator f...

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19527#discussion_r154452715
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala ---
    @@ -41,8 +41,12 @@ import org.apache.spark.sql.types.{DoubleType, NumericType, StructType}
      * The output vectors are sparse.
      *
      * @see `StringIndexer` for converting categorical values into category indices
    + * @deprecated `OneHotEncoderEstimator` will be renamed `OneHotEncoder` and this `OneHotEncoder`
    --- End diff --
    
    Note for the future: For 3.0, it'd be nice to do what you're describing here but also leave OneHotEncoderEstimator as a deprecated alias.  That way, user code won't break but will have deprecation warnings when upgrading to 3.0.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org