You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/04/04 03:23:14 UTC

[GitHub] [beam] lostluck opened a new pull request, #26087: [#25582] Use a Pathing Jar instead of long class paths in Java Boot loader.

lostluck opened a new pull request, #26087:
URL: https://github.com/apache/beam/pull/26087

   Jars are recursive! If the manifest of one contains a manifest with a class path attribute, the JVM will load those jars. This gets around long jar sequences that can make an argument list too long.
   
   This PR fixes an unchanged test in the Java boot_test.go, as well as adds a unit test for the pathing jar. Further, adds the container tests to the Go Tests github action, so this error doesn't recur.
   
   Fixes #25582.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bvolpato commented on a diff in pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on code in PR #26087:
URL: https://github.com/apache/beam/pull/26087#discussion_r1157689063


##########
sdks/java/container/pathingjar.go:
##########
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package main
+
+import (
+	"archive/zip"
+	"fmt"
+	"io"
+	"os"
+	"strings"
+)
+
+func makePathingJar(classpaths []string) (string, error) {
+	f, err := os.Create("pathing.jar")
+	if err != nil {
+		return "", fmt.Errorf("unable to create pathing.jar: %w", err)
+	}
+	defer f.Close()
+	if err := writePathingJar(classpaths, f); err != nil {
+		return "", fmt.Errorf("unable to write pathing.jar: %w", err)
+	}
+	return f.Name(), nil
+}
+
+func writePathingJar(classpaths []string, w io.Writer) error {
+	jar := zip.NewWriter(w)
+	defer jar.Close()
+
+	if _, err := jar.Create("META-INF/"); err != nil {
+		return fmt.Errorf("unable to create META-INF/ directory: %w", err)
+	}
+
+	zf, err := jar.Create("META-INF/MANIFEST.MF")
+	if err != nil {
+		return fmt.Errorf("unable to create META-INF/MANIFEST.MF: %w", err)
+	}
+
+	zf.Write([]byte("Manifest-Version: 1.0\n"))
+	zf.Write([]byte("Class-Path: " + strings.Join(classpaths, " ")))

Review Comment:
   nit: We could use `Created-By: xyz` to be able to trace back from a JAR to this pathing code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on a diff in pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #26087:
URL: https://github.com/apache/beam/pull/26087#discussion_r1157716479


##########
sdks/java/container/pathingjar.go:
##########
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package main
+
+import (
+	"archive/zip"
+	"fmt"
+	"io"
+	"os"
+	"strings"
+)
+
+func makePathingJar(classpaths []string) (string, error) {
+	f, err := os.Create("pathing.jar")
+	if err != nil {
+		return "", fmt.Errorf("unable to create pathing.jar: %w", err)
+	}
+	defer f.Close()
+	if err := writePathingJar(classpaths, f); err != nil {
+		return "", fmt.Errorf("unable to write pathing.jar: %w", err)
+	}
+	return f.Name(), nil
+}
+
+func writePathingJar(classpaths []string, w io.Writer) error {
+	jar := zip.NewWriter(w)
+	defer jar.Close()
+
+	if _, err := jar.Create("META-INF/"); err != nil {
+		return fmt.Errorf("unable to create META-INF/ directory: %w", err)
+	}
+
+	zf, err := jar.Create("META-INF/MANIFEST.MF")
+	if err != nil {
+		return fmt.Errorf("unable to create META-INF/MANIFEST.MF: %w", err)
+	}
+
+	zf.Write([]byte("Manifest-Version: 1.0\n"))
+	zf.Write([]byte("Class-Path: " + strings.Join(classpaths, " ")))

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1500594381

   Run Java Spark PortableValidatesRunner Batch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on a diff in pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #26087:
URL: https://github.com/apache/beam/pull/26087#discussion_r1157655609


##########
.github/workflows/go_tests.yml:
##########
@@ -48,7 +48,7 @@ jobs:
       - name: Delete old coverage
         run: "cd sdks/go/pkg && rm -rf .coverage || :"
       - name: Run coverage
-        run: cd sdks/go/pkg && go test -coverprofile=coverage.txt -covermode=atomic ./...
+        run: cd sdks && go test -coverprofile=coverage.txt -covermode=atomic ./go/pkg/... ./go/container/... ./java/container/... ./python/container/... ./typescript/container/...

Review Comment:
   Enabling covbot here would be out of scope for this change I think. The go tests is different because it's otherwise hard to ensure an action will run, without having a change that ensures the action runs...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1496546564

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1500594092

   Run Java Examples on Dataflow Runner V2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1503876653

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495311243

   Run Java Examples on Dataflow Runner V2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1496546264

   Run Java Flink PortableValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1500595432

   I had misunderstood something in my earlier research: The classpath appends are URIs, not file paths. URIs are in a format like <scheme>:<path>. In this case since it should be all jar files, the class paths should be prefixed with `file:`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495310533

   Run Java 11 Examples on Dataflow Runner V2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1503751120

   Apparently line lengths can't exceed 72 bytes. The more you know! Not hard to fix though (and validate in testing).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1503825535

   Run Java Examples on Dataflow Runner V2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495296114

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on a diff in pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #26087:
URL: https://github.com/apache/beam/pull/26087#discussion_r1157655609


##########
.github/workflows/go_tests.yml:
##########
@@ -48,7 +48,7 @@ jobs:
       - name: Delete old coverage
         run: "cd sdks/go/pkg && rm -rf .coverage || :"
       - name: Run coverage
-        run: cd sdks/go/pkg && go test -coverprofile=coverage.txt -covermode=atomic ./...
+        run: cd sdks && go test -coverprofile=coverage.txt -covermode=atomic ./go/pkg/... ./go/container/... ./java/container/... ./python/container/... ./typescript/container/...

Review Comment:
   Enabling covbot here would be out of scope for this change I think. The go tests is different because it's otherwise hard to ensure an action will run, without having a change that ensures the action runs and that was fixing a clear gap.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1500594314

   Run Java Dataflow V2 ValidatesRunner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495297364

   Run Java Flink PortableValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1503875157

   Run Java Dataflow V2 ValidatesRunner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26087:
URL: https://github.com/apache/beam/pull/26087#discussion_r1157276125


##########
.github/workflows/go_tests.yml:
##########
@@ -48,7 +48,7 @@ jobs:
       - name: Delete old coverage
         run: "cd sdks/go/pkg && rm -rf .coverage || :"
       - name: Run coverage
-        run: cd sdks/go/pkg && go test -coverprofile=coverage.txt -covermode=atomic ./...
+        run: cd sdks && go test -coverprofile=coverage.txt -covermode=atomic ./go/pkg/... ./go/container/... ./java/container/... ./python/container/... ./typescript/container/...

Review Comment:
   Question: does codecov count uncovered non-go files (e.g. https://github.com/apache/beam/blob/master/sdks/java/container/license_scripts/pull_licenses_java.py)? I'm wondering if it makes sense to run container tests separately outside of the context of codecov (I'm leaning towards thinking that they should be included so this is probably a no-op).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1496545118

   Run Java Spark PortableValidatesRunner Batch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1496544927

   Run Java Dataflow V2 ValidatesRunner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1496545430

   Run Java Examples on Dataflow Runner V2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1503874278

   Run Java Flink PortableValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495315876

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @kennknowles for label java.
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495297805

   Run Java Dataflow V2 ValidatesRunner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on a diff in pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #26087:
URL: https://github.com/apache/beam/pull/26087#discussion_r1157654784


##########
.github/workflows/go_tests.yml:
##########
@@ -48,7 +48,7 @@ jobs:
       - name: Delete old coverage
         run: "cd sdks/go/pkg && rm -rf .coverage || :"
       - name: Run coverage
-        run: cd sdks/go/pkg && go test -coverprofile=coverage.txt -covermode=atomic ./...
+        run: cd sdks && go test -coverprofile=coverage.txt -covermode=atomic ./go/pkg/... ./go/container/... ./java/container/... ./python/container/... ./typescript/container/...

Review Comment:
   It will ignore those files, because it's unaware of files that don't receive any coverage numbers/changes.
   
   I think we also don't have the covbot enabled for these directories either. But I'm less concerned about that than I am about the unit tests being run at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1500594259

   Run Java Flink PortableValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1500603121

   Run Spotless PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26087:
URL: https://github.com/apache/beam/pull/26087#discussion_r1157675055


##########
.github/workflows/go_tests.yml:
##########
@@ -48,7 +48,7 @@ jobs:
       - name: Delete old coverage
         run: "cd sdks/go/pkg && rm -rf .coverage || :"
       - name: Run coverage
-        run: cd sdks/go/pkg && go test -coverprofile=coverage.txt -covermode=atomic ./...
+        run: cd sdks && go test -coverprofile=coverage.txt -covermode=atomic ./go/pkg/... ./go/container/... ./java/container/... ./python/container/... ./typescript/container/...

Review Comment:
   SGTM - was meant to be nonblocking, but I realize now I didn't specify that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1503874922

   Run Java Spark PortableValidatesRunner Batch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck merged pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #26087:
URL: https://github.com/apache/beam/pull/26087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495297628

   Run Dataflow ValidatesRunner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495297172

   Run Java examples on Dataflow Java 11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #26087: [#25582] Use a Pathing Jar instead of long command line class paths in Java Boot loader.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26087:
URL: https://github.com/apache/beam/pull/26087#issuecomment-1495311740

   Run Java Spark PortableValidatesRunner Batch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org