[GitHub] [spark] HyukjinKwon commented on a change in pull request #35751: [SPARK-38433][BUILD] Add shell code style check Actions

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #35751:
URL: https://github.com/apache/spark/pull/35751#discussion_r820535552



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -821,3 +821,27 @@ jobs:
       with:
         name: unit-tests-log-docker-integration--8-${{ needs.configure-jobs.outputs.hadoop }}-hive2.3
         path: "**/target/unit-tests.log"
+
+  shellcheck:
+    needs: [configure-jobs, precondition]
+    name: Run shell code style check
+    if: needs.configure-jobs.outputs.type == 'regular' && fromJson(needs.precondition.outputs.required).build == 'true'
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Checkout Spark repository
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+          repository: apache/spark
+          ref: master
+      - name: Sync the current branch with the latest in Apache Spark
+        if: github.repository != 'apache/spark'
+        run: |
+          git fetch https://github.com/$GITHUB_REPOSITORY.git ${GITHUB_REF#refs/heads/}
+          git -c user.name='Apache Spark Test Account' -c user.email='sparktestacc@gmail.com' merge --no-commit --progress --squash FETCH_HEAD
+          git -c user.name='Apache Spark Test Account' -c user.email='sparktestacc@gmail.com' commit -m "Merged commit"
+      - name: Run ShellCheck
+        uses: ludeeus/action-shellcheck@master

Review comment:
       quick question, can we add a dev script? like dev/linter-python, dev/linter-scala




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org