You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Donny9 (via GitHub)" <gi...@apache.org> on 2023/07/28 05:22:41 UTC
[GitHub] [nuttx] Donny9 opened a new pull request, #9937: drivers/mmcsd_sdio: config timout to write one data block
Donny9 opened a new pull request, #9937:
URL: https://github.com/apache/nuttx/pull/9937
## Summary
drivers/mmcsd_sdio: config timout to write one data block
Some hardware needs to config this delay to write one data block, because
the hardware needs more time to wear leveling and bad block manage.
## Impact
## Testing
local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] davids5 commented on a diff in pull request #9937: drivers/mmcsd_sdio: config timout to write one data block
Posted by "davids5 (via GitHub)" <gi...@apache.org>.
davids5 commented on code in PR #9937:
URL: https://github.com/apache/nuttx/pull/9937#discussion_r1277170119
##########
drivers/mmcsd/Kconfig:
##########
@@ -163,6 +163,13 @@ config SDIO_BLOCKSETUP
number of blocks. Others just work on the byte stream. This option
enables the block setup method in the SDIO vtable.
+config MMCSD_BLOCK_WDATADELAY
+ int "The wait timeout to write one data block"
+ default 260
+ ---help---
+ Some hardware needs to config this delay to write one data block, because
+ the hardware needs more time to wear leveling and bad block manage.
Review Comment:
```suggestion
the hardware needs more time to wear leveling and bad block management.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] davids5 commented on a diff in pull request #9937: drivers/mmcsd_sdio: config timout to write one data block
Posted by "davids5 (via GitHub)" <gi...@apache.org>.
davids5 commented on code in PR #9937:
URL: https://github.com/apache/nuttx/pull/9937#discussion_r1277170119
##########
drivers/mmcsd/Kconfig:
##########
@@ -163,6 +163,13 @@ config SDIO_BLOCKSETUP
number of blocks. Others just work on the byte stream. This option
enables the block setup method in the SDIO vtable.
+config MMCSD_BLOCK_WDATADELAY
+ int "The wait timeout to write one data block"
+ default 260
+ ---help---
+ Some hardware needs to config this delay to write one data block, because
+ the hardware needs more time to wear leveling and bad block manage.
Review Comment:
```suggestion
the hardware needs more time for wear leveling and bad block management.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] davids5 commented on a diff in pull request #9937: drivers/mmcsd_sdio: config timout to write one data block
Posted by "davids5 (via GitHub)" <gi...@apache.org>.
davids5 commented on code in PR #9937:
URL: https://github.com/apache/nuttx/pull/9937#discussion_r1277170692
##########
drivers/mmcsd/Kconfig:
##########
@@ -163,6 +163,13 @@ config SDIO_BLOCKSETUP
number of blocks. Others just work on the byte stream. This option
enables the block setup method in the SDIO vtable.
+config MMCSD_BLOCK_WDATADELAY
+ int "The wait timeout to write one data block"
+ default 260
+ ---help---
+ Some hardware needs to config this delay to write one data block, because
Review Comment:
```suggestion
Some hardware needs to configure this delay to write one data block, because
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Donny9 commented on a diff in pull request #9937: drivers/mmcsd_sdio: config timout to write one data block
Posted by "Donny9 (via GitHub)" <gi...@apache.org>.
Donny9 commented on code in PR #9937:
URL: https://github.com/apache/nuttx/pull/9937#discussion_r1277176523
##########
drivers/mmcsd/Kconfig:
##########
@@ -163,6 +163,13 @@ config SDIO_BLOCKSETUP
number of blocks. Others just work on the byte stream. This option
enables the block setup method in the SDIO vtable.
+config MMCSD_BLOCK_WDATADELAY
+ int "The wait timeout to write one data block"
+ default 260
+ ---help---
+ Some hardware needs to config this delay to write one data block, because
+ the hardware needs more time to wear leveling and bad block manage.
Review Comment:
Done~
##########
drivers/mmcsd/Kconfig:
##########
@@ -163,6 +163,13 @@ config SDIO_BLOCKSETUP
number of blocks. Others just work on the byte stream. This option
enables the block setup method in the SDIO vtable.
+config MMCSD_BLOCK_WDATADELAY
+ int "The wait timeout to write one data block"
+ default 260
+ ---help---
+ Some hardware needs to config this delay to write one data block, because
Review Comment:
Done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9937: drivers/mmcsd_sdio: config timout to write one data block
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9937:
URL: https://github.com/apache/nuttx/pull/9937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org