[GitHub] [spark] viirya commented on a change in pull request #32221: [SPARK-35125][K8S] Upgrade K8s client to 5.3.0 to support K8s 1.20

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #32221:
URL: https://github.com/apache/spark/pull/32221#discussion_r615445958



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSource.scala
##########
@@ -58,10 +58,14 @@ private[spark] class ExecutorPodsWatchSnapshotSource(
       snapshotsStore.updatePod(pod)
     }
 
-    override def onClose(e: KubernetesClientException): Unit = {
+    override def onClose(e: WatcherException): Unit = {
       logWarning("Kubernetes client has been closed (this is expected if the application is" +

Review comment:
       > As I see the current log message is misleading. If this method with the exception is called then "(this is expected if the application is shutting down.)" part is not true. So I think we should at least change that.
   
   I guess @attilapiros comment is we are better to revise this log message? As this is exception case, it may not "this is expected".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org