You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/19 01:41:02 UTC

[GitHub] [arrow] kou commented on a change in pull request #7420: ARROW-9022: [C++] Add/Sub/Mul arithmetic kernels with overflow check

kou commented on a change in pull request #7420:
URL: https://github.com/apache/arrow/pull/7420#discussion_r442586794



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -43,7 +48,9 @@ namespace compute {
 /// \param[in] ctx the function execution context, optional
 /// \return the elementwise sum
 ARROW_EXPORT
-Result<Datum> Add(const Datum& left, const Datum& right, ExecContext* ctx = NULLPTR);
+Result<Datum> Add(const Datum& left, const Datum& right,
+                  ArithmeticOptions options = ArithmeticOptions(),

Review comment:
       We need to document this.
   This breaks CI: https://github.com/apache/arrow/runs/786249626




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org