[GitHub] [phoenix] twdsilva commented on a change in pull request #485: Add common utility function ScanUtil.splityKeyRangesByBoundaries()

[GitBox <gi...@apache.org>]

twdsilva commented on a change in pull request #485: Add common utility function ScanUtil.splityKeyRangesByBoundaries()
URL: https://github.com/apache/phoenix/pull/485#discussion_r276833880
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
 ##########
 @@ -953,4 +953,85 @@ public static int getClientVersion(Scan scan) {
     public static void setClientVersion(Scan scan, int version) {
         scan.setAttribute(BaseScannerRegionObserver.CLIENT_VERSION, Bytes.toBytes(version));
     }
+
+    /**
+     * Split the key ranges into multiple groups along the given boundaries
+     *
+     * @param boundaries
+     *     The boundaries is a byte[] list like "b0, b1, ..., bn" which forms
+     *     space (UNBOUND, b0), [b0, b1), ..., [bn, UNBOUND). Every boundary
+     *     can't be null or empty.
+     * @param keyRanges
+     *     The key ranges to split along the given boundaries. Coalesced.
+     * @return
+     *     List<Pair<RangeIndex, Query Key Range List in this range>>.
 
 Review comment:
   should this be List<Pair<BoundaryIndex, Query Key Range List in this boundary>> ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services