You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "nathanwilliams-ct (via GitHub)" <gi...@apache.org> on 2026/07/17 13:15:09 UTC
[PR] Element: Remove unused & deprecated node_subst methods [buildstream]
nathanwilliams-ct opened a new pull request, #2154:
URL: https://github.com/apache/buildstream/pull/2154
These deprecation notices were introduced into the codebase [6 years ago (April 16th, 2020 5:56 PM)](e5ed02da0b99c16481eac58963f4ebbdf0481590)
There have been many Buildstream versions since then, a search in the Buildstream codebase shows they are unused, so it's about time they are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5183131526
Please do port the community plugins. It's a good concrete example why the API is not needed. Presuming it's not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "nathanwilliams-ct (via GitHub)" <gi...@apache.org>.
nathanwilliams-ct commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5393989445
> https://gitlab.com/BuildStream/buildstream-plugins-community/-/merge_requests/454
This has now been merged into community plugins. So release 2.4 of community plugins won't use this API any more.
Unless there are any other users climb out of the woodwork, this PR can be included in a theoretical 3.0 release of Buildstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5004284864
Unfortunately, this is part of the public plugin API where we guarantee stability across stable releases. We failed to remove it before 2.0. And some plugins in buildstream-plugins-community are even still using it, should probably fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5183143223
Necessary API could obviously be undeprecated and porting plugins is good case study.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "jjardon (via GitHub)" <gi...@apache.org>.
jjardon commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5185854748
> I don't think we have an issue in https://gitlab.com/BuildStream/buildstream-plugins-community/ for this, probably makes sense to open one.
I have opened https://gitlab.com/BuildStream/buildstream-plugins-community/-/work_items/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5070601478
I don't think we have an issue in https://gitlab.com/BuildStream/buildstream-plugins-community/ for this, probably makes sense to open one.
We also don't have a milestone or label for BuildStream 3.0, not sure whether we should create one without more specific plans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "nathanwilliams-ct (via GitHub)" <gi...@apache.org>.
nathanwilliams-ct commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5356450681
https://gitlab.com/BuildStream/buildstream-plugins-community/-/merge_requests/454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "IdrisTheDragon (via GitHub)" <gi...@apache.org>.
IdrisTheDragon commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5004651824
So this PR is a candidate for 3.0 assuming we sort the buildstream community plugins for it. Do you know if there's an issue to track this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Element: Remove unused & deprecated node_subst methods [buildstream]
Posted by "IdrisTheDragon (via GitHub)" <gi...@apache.org>.
IdrisTheDragon commented on PR #2154:
URL: https://github.com/apache/buildstream/pull/2154#issuecomment-5071229199
Might be worth creating a label at minimum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org