Re: [PR] [SparkConnector] Add proper time column support for Spark connector segment writer [pinot]

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on code in PR #14556:
URL: https://github.com/apache/pinot/pull/14556#discussion_r1866418294


##########
pinot-connectors/pinot-spark-3-connector/src/main/scala/org/apache/pinot/connector/spark/v3/datasource/PinotDataWriter.scala:
##########
@@ -94,6 +115,8 @@ class PinotDataWriter[InternalRow](
     val variables = Map(
       "partitionId" -> partitionId,
       "table" -> tableName,
+      "startTime" -> startTime,

Review Comment:
   nit: you can also update javadocs to show the new variables for segment name generation. But do call out that it only works for numeric time columns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org