[GitHub] [incubator-kvrocks] kezhenxu94 commented on issue #718: Build docker image with Travis CI

[GitBox <gi...@apache.org>]

kezhenxu94 commented on issue #718:
URL: https://github.com/apache/incubator-kvrocks/issues/718#issuecomment-1175905750

   Personally I'd prefer GitHub Actions over Travis CI as GHA is integrated smoothly in terms of development experience, and you don't need to ask Apache infra team to provide token and configure them in Travis CI (this is usually forbidden by infra team for the sake of security).
   
   > Thanks. I think it maybe unnecessary to build docker images for every commit in a PR: we've fully tested them in other workflows.
   
   I agree we don't need to build Docker images in every commit **in a PR**, not to say pushing/publishing to GitHub Container Registry, ghcr,
   
   > I think we can consider building docker images for each new commit in the unstable branch and release it as a nightly version (of course we can do some pruning when releasing to ensure that only one nightly image is released per day).
   
   In SkyWalking, we build and push a Docker image for every commit in the `master` branch, tagged with the commit hash as well as the `latest` tag, so we'd recommend testers (not users) to use the `:latest` tag when they want to try something new, or help to test the latest codes.
   
   Also, to build multi-arch Docker images, you actually don't need an ARM-arch machine, by leveraging qemu and Docker build kit you can cross build Docker images for all architectures https://github.com/apache/skywalking/blob/47cc2f7bb99fefda37a3adcc85206e1743d32757/.github/workflows/publish-docker.yaml#L55-L58
   
   And to just build for every commit in `master` branch, just set the `on` condition to `branch.master` so the workflow won't be triggered in PR commits
   
   https://github.com/apache/skywalking/blob/47cc2f7bb99fefda37a3adcc85206e1743d32757/.github/workflows/publish-docker.yaml#L19-L22
   
   All the works 👆 can be done on your own, without asking apache infra team to configure tokens, which is impossible in Travis CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org