You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by iv...@apache.org on 2023/01/21 15:57:47 UTC
svn commit: r1906887 - /apr/apr/trunk/threadproc/win32/proc.c
Author: ivan
Date: Sat Jan 21 15:57:47 2023
New Revision: 1906887
URL: http://svn.apache.org/viewvc?rev=1906887&view=rev
Log:
Simplify code.
* threadproc/win32/proc.c
(apr_proc_create): Use apr_wchar_t for pEnvBlock local variable and avoid
unnecessary casts.
Modified:
apr/apr/trunk/threadproc/win32/proc.c
Modified: apr/apr/trunk/threadproc/win32/proc.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/threadproc/win32/proc.c?rev=1906887&r1=1906886&r2=1906887&view=diff
==============================================================================
--- apr/apr/trunk/threadproc/win32/proc.c (original)
+++ apr/apr/trunk/threadproc/win32/proc.c Sat Jan 21 15:57:47 2023
@@ -503,7 +503,7 @@ APR_DECLARE(apr_status_t) apr_proc_creat
apr_size_t i;
const char *argv0;
char *cmdline;
- char *pEnvBlock;
+ apr_wchar_t *pEnvBlock;
PROCESS_INFORMATION pi;
DWORD dwCreationFlags = 0;
@@ -702,11 +702,11 @@ APR_DECLARE(apr_status_t) apr_proc_creat
{
apr_wchar_t *pNext;
- pEnvBlock = (char *)apr_palloc(pool, iEnvBlockLen * sizeof(apr_wchar_t));
+ pEnvBlock = apr_palloc(pool, iEnvBlockLen * sizeof(apr_wchar_t));
dwCreationFlags |= CREATE_UNICODE_ENVIRONMENT;
i = 0;
- pNext = (apr_wchar_t*)pEnvBlock;
+ pNext = pEnvBlock;
while (env[i]) {
apr_size_t in = strlen(env[i]) + 1;
if ((rv = apr_conv_utf8_to_utf16(env[i], &in,