You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2018/04/04 06:37:42 UTC

[GitHub] carbondata pull request #2138: [CARBONDATA-2230][Documentation]add documenta...

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2138

    [CARBONDATA-2230][Documentation]add documentation for segment lock files clean up configuration

    added documentation for segment lock files clean up configuration
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2138
    
----
commit 97424c066d1d8f719566aff186ad2373475d748b
Author: akashrn5 <ak...@...>
Date:   2018-04-04T06:36:21Z

    Update configuration-parameters.md

----


---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2138
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3582/



---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2138
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3690/



---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

Posted by sgururajshetty <gi...@git.apache.org>.
Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/2138
  
    LGTM


---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2138
  
    retest this please


---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2138
  
    LGTM


---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2138
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4913/



---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2138
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4806/



---

[GitHub] carbondata pull request #2138: [CARBONDATA-2230][Documentation]add documenta...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2138


---

[GitHub] carbondata pull request #2138: [CARBONDATA-2230][Documentation]add documenta...

Posted by sgururajshetty <gi...@git.apache.org>.
Github user sgururajshetty commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2138#discussion_r179039767
  
    --- Diff: docs/configuration-parameters.md ---
    @@ -39,6 +39,7 @@ This section provides the details of all the configurations required for the Car
     | carbon.streaming.auto.handoff.enabled | true | If this parameter value is set to true, auto trigger handoff function will be enabled.|
     | carbon.streaming.segment.max.size | 1024000000 | This parameter defines the maximum size of the streaming segment. Setting this parameter to appropriate value will avoid impacting the streaming ingestion. The value is in bytes.|
     | carbon.query.show.datamaps | true | If this parameter value is set to true, show tables command will list all the tables including datatmaps(eg: Preaggregate table), else datamaps will be excluded from the table list. |
    +| carbon.segment.lock.files.preserve.hours | 48 | This property value indicates the number of hours the segment lock files will be preserved after dataload. These lock fils will be deleted with clean files command after the configured amount of hours. |
    --- End diff --
    
    Spelling error "fils"
    
    These lock files will be deleted with the clean command after the configured number of hours. 


---