You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hannahkamundson (via GitHub)" <gi...@apache.org> on 2024/01/21 20:40:14 UTC
[PR] [WIP][SPARK-42332][SQL] Reverting an import change that shouldn't have been made [spark]
hannahkamundson opened a new pull request, #44822:
URL: https://github.com/apache/spark/pull/44822
### What changes were proposed in this pull request?
I changed an import to an import all instead of import specifics. Per this comment: https://github.com/apache/spark/pull/44336#discussion_r1461103077
### Why are the changes needed?
Revert the import back
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CICD tests
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42332][SQL] Reverting an import change that shouldn't have been made [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44822:
URL: https://github.com/apache/spark/pull/44822#issuecomment-1902759338
@hannahkamundson I think the issue is too minor. You can address it in another PR if you are going to work on the error framework. Let's close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42332][SQL] Reverting an import change that shouldn't have been made [spark]
Posted by "hannahkamundson (via GitHub)" <gi...@apache.org>.
hannahkamundson commented on PR #44822:
URL: https://github.com/apache/spark/pull/44822#issuecomment-1902758711
@MaxGekk Here is the fix. I'm not sure wy the pull request target isn't working though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42332][SQL] Reverting an import change that shouldn't have been made [spark]
Posted by "hannahkamundson (via GitHub)" <gi...@apache.org>.
hannahkamundson closed pull request #44822: [SPARK-42332][SQL] Reverting an import change that shouldn't have been made
URL: https://github.com/apache/spark/pull/44822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42332][SQL] Reverting an import change that shouldn't have been made [spark]
Posted by "hannahkamundson (via GitHub)" <gi...@apache.org>.
hannahkamundson commented on PR #44822:
URL: https://github.com/apache/spark/pull/44822#issuecomment-1902766341
Ok sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org