You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/21 13:01:42 UTC

[GitHub] [arrow] projjal commented on a change in pull request #10033: ARROW-12388: [C++][Gandiva] Implement cast numbers from varbinary functions in gandiva

projjal commented on a change in pull request #10033:
URL: https://github.com/apache/arrow/pull/10033#discussion_r617511000



##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -307,6 +306,37 @@ CAST_NUMERIC_FROM_STRING(double, arrow::DoubleType, FLOAT8)
 
 #undef CAST_NUMERIC_FROM_STRING
 
+#define CAST_NUMERIC_FROM_VARBINARY(OUT_TYPE, ARROW_TYPE, TYPE_NAME)                   \
+  GANDIVA_EXPORT                                                                       \
+  OUT_TYPE gdv_fn_cast##TYPE_NAME##_varbinary(int64_t context, const char* data,       \

Review comment:
       Is it any different from CAST_NUMERIC_FROM_STRING functions. Can't you just call them




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org