(lucene) branch branch_9x updated: Make TestDrillSideways#testCollectionTerminated less strict (#12920)

[gs...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gsmiller pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/lucene.git


The following commit(s) were added to refs/heads/branch_9x by this push:
     new 7c8d7aef42a Make TestDrillSideways#testCollectionTerminated less strict (#12920)
7c8d7aef42a is described below

commit 7c8d7aef42aa99eaaa2038d00aa59d9a509e182d
Author: Greg Miller <gs...@gmail.com>
AuthorDate: Mon Dec 11 19:20:08 2023 -0800

    Make TestDrillSideways#testCollectionTerminated less strict (#12920)
---
 lucene/CHANGES.txt                                                   | 3 +++
 lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java | 4 ----
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 4860b81579f..071b3f3e78b 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -42,6 +42,9 @@ Bug Fixes
 * GITHUB#12558: Ensure #finish is called on all drill-sideways FacetsCollectors even when no hits are scored.
   (Greg Miller)
 
+* GITHUB#12920: Address bug in TestDrillSideways#testCollectionTerminated that could occasionally cause the test to
+  fail with certain random seeds. (Greg Miller)
+
 Other
 ---------------------
 * GITHUB#11023: Removing some dead code in CheckIndex. (Jakub Slowinski)
diff --git a/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java b/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java
index a4b7879e742..5b85066665f 100644
--- a/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java
+++ b/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java
@@ -326,10 +326,6 @@ public class TestDrillSideways extends FacetTestCase {
         // termination occurs (i.e., #finish is properly called in that scenario):
         assertEquals(1, baseFC.getMatchingDocs().size());
         assertEquals(1, dimFC.getMatchingDocs().size());
-        FacetsCollector.MatchingDocs baseMD = baseFC.getMatchingDocs().get(0);
-        FacetsCollector.MatchingDocs dimMD = dimFC.getMatchingDocs().get(0);
-        assertEquals(1, baseMD.totalHits);
-        assertEquals(1, dimMD.totalHits);
       }
     }
   }