[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore

[GitBox <gi...@apache.org>]

zxcware commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r402643365
 
 

 ##########
 File path: gobblin-metastore/src/main/java/org/apache/gobblin/metastore/FsStateStore.java
 ##########
 @@ -378,4 +387,48 @@ public void delete(String storeName) throws IOException {
       this.fs.delete(storePath, true);
     }
   }
+
+  @Override
+  public Map<String, T> getLatestDatasetStatesByUrns(String jobName) throws IOException {
+    throw new UnsupportedOperationException();
+  }
+
+  @Override
+  public T getLatestDatasetState(String storeName, String datasetUrn) throws IOException {
+    throw new UnsupportedOperationException();
+  }
+
+  @Override
+  public void persistDatasetState(String datasetUrn, T datasetState) throws IOException {
+    throw new UnsupportedOperationException();
+  }
+
+  @Override
+  public void persistDatasetURNs(String storeName, Collection<String> datasetUrns) throws IOException {
+    throw new UnsupportedOperationException();
+  }
+
+  @Override
+  public List<? extends StateStoreEntryManager> getMetadataForTables(StateStorePredicate predicate) {
 
 Review comment:
    Should it be `DatasetStateStoreEntryManager` to correct serve its role as dataset state store?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services