[GitHub] [incubator-druid] gianm commented on a change in pull request #7810: Remove Apache Pig from the tests

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #7810: Remove Apache Pig from the tests
URL: https://github.com/apache/incubator-druid/pull/7810#discussion_r291993311
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectFlatteners.java
 ##########
 @@ -32,13 +32,8 @@
 import java.util.function.Function;
 import java.util.stream.Collectors;
 
-public class ObjectFlatteners
+public abstract class ObjectFlatteners
 
 Review comment:
   In Druid code it's normal for classes like this (that contain only static methods) to be non-abstract and have a private constructor with a comment like "No instantiation" or "Static methods only". It's just a way of working around the fact that everything in Java must be a class, even things like this that don't really make sense as OO style classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org