You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/09/21 19:19:00 UTC

[jira] [Work logged] (GOBBLIN-1268) track workunits created in gaas jobs

     [ https://issues.apache.org/jira/browse/GOBBLIN-1268?focusedWorklogId=487216&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487216 ]

ASF GitHub Bot logged work on GOBBLIN-1268:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/20 19:18
            Start Date: 21/Sep/20 19:18
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 opened a new pull request #3108:
URL: https://github.com/apache/incubator-gobblin/pull/3108


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   @sv2000 please review
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1268
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   1) this PR moves the code block for setting number of workunits in job state at a more appropriate place
   2) make gaas job status monitor track WORK_UNITS_PREPARATION timer event also. this event is emitted after the job start timer. the reason for tracking this is that WORK_UNITS_PREPARATION will have NUM_WORKUNITS set which are not set by the time job start event is emitted
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   trivial changes
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 487216)
    Remaining Estimate: 0h
            Time Spent: 10m

> track workunits created in gaas jobs
> ------------------------------------
>
>                 Key: GOBBLIN-1268
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1268
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)