You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Justin Lee (JIRA)" <ji...@apache.org> on 2009/08/06 16:41:14 UTC

[jira] Created: (HARMONY-6298) LogManager breaks on subclassing

LogManager breaks on subclassing
--------------------------------

                 Key: HARMONY-6298
                 URL: https://issues.apache.org/jira/browse/HARMONY-6298
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
         Environment: AIX, IBM's java6, glassfishv2
            Reporter: Justin Lee
            Priority: Critical


In LogManager.readConfiguration() after the config file is found, a call is made to the private method readConfigurationImpl(InputStream) rather than the public readConfiguration(InputStream).  In glassfishv2, our ServerLogManger overrides readConfiguration(InputStream) but it never gets called on AIX under java6 because readConfiguration(InputStream) is skipped over in favor of readConfigurationImpl().  This causes glassfishv2 to break catastrophically.  readConfiguration() should call readConfiguration(InputStream) instead so that others may override behavior as necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-6298) LogManager breaks on subclassing

Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Qiu reassigned HARMONY-6298:
---------------------------------

    Assignee: Sean Qiu

> LogManager breaks on subclassing
> --------------------------------
>
>                 Key: HARMONY-6298
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6298
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX, IBM's java6, glassfishv2
>            Reporter: Justin Lee
>            Assignee: Sean Qiu
>            Priority: Critical
>
> In LogManager.readConfiguration() after the config file is found, a call is made to the private method readConfigurationImpl(InputStream) rather than the public readConfiguration(InputStream).  In glassfishv2, our ServerLogManger overrides readConfiguration(InputStream) but it never gets called on AIX under java6 because readConfiguration(InputStream) is skipped over in favor of readConfigurationImpl().  This causes glassfishv2 to break catastrophically.  readConfiguration() should call readConfiguration(InputStream) instead so that others may override behavior as necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6298) LogManager breaks on subclassing

Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Qiu resolved HARMONY-6298.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M11

The patch had been committed at r802638.
Please verify it if it works as you expected.
Thanks very much for your contribution.

> LogManager breaks on subclassing
> --------------------------------
>
>                 Key: HARMONY-6298
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6298
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX, IBM's java6, glassfishv2
>            Reporter: Justin Lee
>            Assignee: Sean Qiu
>            Priority: Critical
>             Fix For: 5.0M11
>
>         Attachments: HARMONY-6298.diff
>
>
> In LogManager.readConfiguration() after the config file is found, a call is made to the private method readConfigurationImpl(InputStream) rather than the public readConfiguration(InputStream).  In glassfishv2, our ServerLogManger overrides readConfiguration(InputStream) but it never gets called on AIX under java6 because readConfiguration(InputStream) is skipped over in favor of readConfigurationImpl().  This causes glassfishv2 to break catastrophically.  readConfiguration() should call readConfiguration(InputStream) instead so that others may override behavior as necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6298) LogManager breaks on subclassing

Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Qiu updated HARMONY-6298:
------------------------------

    Attachment: HARMONY-6298.diff

Could someone please help review this patch? 
I'm not sure whether you can build our code. If not, Other developers of our community will review this patch first. 
If there is no objections to this patch,I will apply it for you and you can pick up our snapshot to verify then.




> LogManager breaks on subclassing
> --------------------------------
>
>                 Key: HARMONY-6298
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6298
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX, IBM's java6, glassfishv2
>            Reporter: Justin Lee
>            Assignee: Sean Qiu
>            Priority: Critical
>         Attachments: HARMONY-6298.diff
>
>
> In LogManager.readConfiguration() after the config file is found, a call is made to the private method readConfigurationImpl(InputStream) rather than the public readConfiguration(InputStream).  In glassfishv2, our ServerLogManger overrides readConfiguration(InputStream) but it never gets called on AIX under java6 because readConfiguration(InputStream) is skipped over in favor of readConfigurationImpl().  This causes glassfishv2 to break catastrophically.  readConfiguration() should call readConfiguration(InputStream) instead so that others may override behavior as necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6298) LogManager breaks on subclassing

Posted by "Justin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740517#action_12740517 ] 

Justin Lee commented on HARMONY-6298:
-------------------------------------

The attached diff looks like the fix I'd make as well though I'm not set up to build and test it at the moment.

> LogManager breaks on subclassing
> --------------------------------
>
>                 Key: HARMONY-6298
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6298
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX, IBM's java6, glassfishv2
>            Reporter: Justin Lee
>            Assignee: Sean Qiu
>            Priority: Critical
>         Attachments: HARMONY-6298.diff
>
>
> In LogManager.readConfiguration() after the config file is found, a call is made to the private method readConfigurationImpl(InputStream) rather than the public readConfiguration(InputStream).  In glassfishv2, our ServerLogManger overrides readConfiguration(InputStream) but it never gets called on AIX under java6 because readConfiguration(InputStream) is skipped over in favor of readConfigurationImpl().  This causes glassfishv2 to break catastrophically.  readConfiguration() should call readConfiguration(InputStream) instead so that others may override behavior as necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6298) LogManager breaks on subclassing

Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740416#action_12740416 ] 

Sean Qiu commented on HARMONY-6298:
-----------------------------------

SecurityPermission check is deplay to readConfiguration(Input) to avoid duplication.
If anyone have a better solution, please go ahead.

> LogManager breaks on subclassing
> --------------------------------
>
>                 Key: HARMONY-6298
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6298
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX, IBM's java6, glassfishv2
>            Reporter: Justin Lee
>            Assignee: Sean Qiu
>            Priority: Critical
>         Attachments: HARMONY-6298.diff
>
>
> In LogManager.readConfiguration() after the config file is found, a call is made to the private method readConfigurationImpl(InputStream) rather than the public readConfiguration(InputStream).  In glassfishv2, our ServerLogManger overrides readConfiguration(InputStream) but it never gets called on AIX under java6 because readConfiguration(InputStream) is skipped over in favor of readConfigurationImpl().  This causes glassfishv2 to break catastrophically.  readConfiguration() should call readConfiguration(InputStream) instead so that others may override behavior as necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6298) LogManager breaks on subclassing

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess updated HARMONY-6298:
----------------------------------

    Fix Version/s:     (was: 5.0M11)

Removing java6 bug from "Fixed in 5.0M11 set".

> LogManager breaks on subclassing
> --------------------------------
>
>                 Key: HARMONY-6298
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6298
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX, IBM's java6, glassfishv2
>            Reporter: Justin Lee
>            Assignee: Sean Qiu
>            Priority: Critical
>         Attachments: HARMONY-6298.diff
>
>
> In LogManager.readConfiguration() after the config file is found, a call is made to the private method readConfigurationImpl(InputStream) rather than the public readConfiguration(InputStream).  In glassfishv2, our ServerLogManger overrides readConfiguration(InputStream) but it never gets called on AIX under java6 because readConfiguration(InputStream) is skipped over in favor of readConfigurationImpl().  This causes glassfishv2 to break catastrophically.  readConfiguration() should call readConfiguration(InputStream) instead so that others may override behavior as necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6298) LogManager breaks on subclassing

Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740116#action_12740116 ] 

Sean Qiu commented on HARMONY-6298:
-----------------------------------

I do find a potential defect in this module.
I will investigate it and supply a fix as soon as possible.

> LogManager breaks on subclassing
> --------------------------------
>
>                 Key: HARMONY-6298
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6298
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX, IBM's java6, glassfishv2
>            Reporter: Justin Lee
>            Assignee: Sean Qiu
>            Priority: Critical
>
> In LogManager.readConfiguration() after the config file is found, a call is made to the private method readConfigurationImpl(InputStream) rather than the public readConfiguration(InputStream).  In glassfishv2, our ServerLogManger overrides readConfiguration(InputStream) but it never gets called on AIX under java6 because readConfiguration(InputStream) is skipped over in favor of readConfigurationImpl().  This causes glassfishv2 to break catastrophically.  readConfiguration() should call readConfiguration(InputStream) instead so that others may override behavior as necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.