You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by co...@apache.org on 2017/03/02 10:02:54 UTC

ranger git commit: RANGER-1408:When the error occurs, the system does not record the error message in RangerServiceService class

Repository: ranger
Updated Branches:
  refs/heads/master 6a602cadc -> ec858915d


RANGER-1408:When the error occurs, the system does not record the error message in RangerServiceService class

Signed-off-by: Colm O hEigeartaigh <co...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/ec858915
Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/ec858915
Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/ec858915

Branch: refs/heads/master
Commit: ec858915dc5efa8111de0804005776fb56ac4c23
Parents: 6a602ca
Author: zhangqiang2 <zh...@zte.com.cn>
Authored: Mon Feb 27 07:10:35 2017 -0500
Committer: Colm O hEigeartaigh <co...@apache.org>
Committed: Thu Mar 2 09:56:37 2017 +0000

----------------------------------------------------------------------
 .../org/apache/ranger/service/RangerServiceService.java   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ranger/blob/ec858915/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
----------------------------------------------------------------------
diff --git a/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java b/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
index 0d97298..c666a1c 100644
--- a/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
+++ b/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
@@ -25,6 +25,7 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.logging.Logger;
 
 import org.apache.commons.lang.StringUtils;
 import org.apache.ranger.biz.ServiceDBStore;
@@ -35,7 +36,6 @@ import org.apache.ranger.common.PropertiesUtil;
 import org.apache.ranger.common.view.VTrxLogAttr;
 import org.apache.ranger.db.XXServiceVersionInfoDao;
 import org.apache.ranger.entity.XXService;
-import org.apache.ranger.entity.XXServiceBase;
 import org.apache.ranger.entity.XXServiceConfigMap;
 import org.apache.ranger.entity.XXServiceDef;
 import org.apache.ranger.entity.XXServiceVersionInfo;
@@ -48,7 +48,7 @@ import org.springframework.stereotype.Service;
 @Service
 @Scope("singleton")
 public class RangerServiceService extends RangerServiceServiceBase<XXService, RangerService> {
-
+	private static final Logger LOG = Logger.getLogger(RangerServiceService.class.getName());
 	@Autowired
 	JSONUtil jsonUtil;
 
@@ -166,9 +166,9 @@ public class RangerServiceService extends RangerServiceServiceBase<XXService, Ra
 				}
 			}
 		} catch (IllegalAccessException e) {
-			e.printStackTrace();
+			LOG.info("Get transaction log failure." + e);
 		} catch (NoSuchFieldException e) {
-			e.printStackTrace();
+			LOG.info("Get transaction log failure." + e);
 		}
 		return trxLogList;
 	}
@@ -275,7 +275,7 @@ public class RangerServiceService extends RangerServiceServiceBase<XXService, Ra
 				xTrxLog.setNewValue(value);
 			}
 		} catch (IllegalArgumentException | IllegalAccessException e) {
-			e.printStackTrace();
+			LOG.info("Process field to create trx log failure." + e);
 		}
 
 		xTrxLog.setAction(actionString);