You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/01/04 23:25:51 UTC
zeppelin git commit: [HOTFIX] fix: DON'T run npm clean in maven clean
phase (CI related, Build failure in web)
Repository: zeppelin
Updated Branches:
refs/heads/master 2b1c6ea3f -> 4723c88a1
[HOTFIX] fix: DON'T run npm clean in maven clean phase (CI related, Build failure in web)
### What is this PR for?
maven clean executes `npm run clean` after #1824. but running npm commands requires installing, it's impossible to clean before installing it.
**This PR resolve CI break** (see broken RAT build profiles)
- https://travis-ci.org/apache/zeppelin/builds/188895921
- https://travis-ci.org/apache/zeppelin/builds/188782988
### What type of PR is it?
[Bug Fix | Hot Fix]
### Todos
Nothing
### What is the Jira issue?
[ZEPPELIN-1850](https://issues.apache.org/jira/browse/ZEPPELIN-1850)
### How should this be tested?
The first build profile (RAT) should pass CI.
### Screenshots (if appropriate)
```
[INFO] --- frontend-maven-plugin:1.3:npm (npm clean) zeppelin-web ---
...
[INFO] Running 'npm run clean' in /Users/lambda/github/apache-zeppelin/zeppelin-bug/zeppelin-web
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.701 s
[INFO] Finished at: 2017-01-05T03:55:32+09:00
[INFO] Final Memory: 21M/982M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm clean) on project zeppelin-web: Failed to run task: 'npm run clean' failed. java.io.IOException: Cannot run program"/Users/lambda/github/apache-zeppelin/zeppelin-bug/zeppelin-web/node/node" (in directory "/Users/lambda/github/apache-zeppelin/zeppelin-bug/zeppelin-web"): error=2, No such file or directory -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm clean) on project zeppelin-web: Failed to run task
...
[ERROR]
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
```
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1a...@gmail.com>
Closes #1841 from 1ambda/fix/invalid-clean-setting-in-zeppelin-web and squashes the following commits:
4f83de1 [1ambda] fix: DON'T run npm command in maven clean phase
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/4723c88a
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/4723c88a
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/4723c88a
Branch: refs/heads/master
Commit: 4723c88a14ac6ec78406cfd0c1341126693743e0
Parents: 2b1c6ea
Author: 1ambda <1a...@gmail.com>
Authored: Thu Jan 5 03:58:38 2017 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Wed Jan 4 15:25:44 2017 -0800
----------------------------------------------------------------------
zeppelin-web/pom.xml | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/4723c88a/zeppelin-web/pom.xml
----------------------------------------------------------------------
diff --git a/zeppelin-web/pom.xml b/zeppelin-web/pom.xml
index d9b1235..2017a21 100644
--- a/zeppelin-web/pom.xml
+++ b/zeppelin-web/pom.xml
@@ -146,17 +146,6 @@
</configuration>
</execution>
- <execution>
- <id>npm clean</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <phase>clean</phase>
- <configuration>
- <arguments>run clean</arguments>
- </configuration>
- </execution>
-
</executions>
</plugin>
@@ -186,6 +175,19 @@
<plugin>
<!-- clean task will be executed by front-end-maven plugin -->
<artifactId>maven-clean-plugin</artifactId>
+ <configuration>
+ <filesets>
+ <fileset>
+ <directory>bower_components</directory>
+ </fileset>
+ <fileset>
+ <directory>node</directory>
+ </fileset>
+ <fileset>
+ <directory>node_modules</directory>
+ </fileset>
+ </filesets>
+ </configuration>
</plugin>
</plugins>
</build>