[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

[GitBox <gi...@apache.org>]

ZanderXu commented on code in PR #5088:
URL: https://github.com/apache/hadoop/pull/5088#discussion_r1011412575


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2879,9 +2881,12 @@ private void processRpcRequest(RpcRequestHeaderProto header,
             stateId = alignmentContext.receiveRequestState(
                 header, getMaxIdleTime());
             call.setClientStateId(stateId);
-            if (header.hasRouterFederatedState()) {
-              call.setFederatedNamespaceState(header.getRouterFederatedState());
-            }
+          }
+          if (header.hasRouterFederatedState()) {
+            call.setFederatedNamespaceState(header.getRouterFederatedState());
+          } else if (header.hasStateId()) {
+            // Only used to determine whether to return federatedNamespaceState.
+            call.setFederatedNamespaceState(EMPTY_BYTE_STRING);

Review Comment:
   @simbadzina Master, thanks for your review.
   
   Here set the EMPTY_BYTE_STRING to identify that the client want to get all nameservice's stateId. So that `RouterStateIdContext` can set ResponseHeaderState.
   
   I think there are too cases that identifying the client want to get the stateId from server.
   1. header.hasStateId()
   2. header.hasRouterFederatedState()
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org