You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/08/07 01:43:49 UTC
[GitHub] [activemq-nms-openwire] killnine commented on a change in pull
request #9: [AMQNET-565] - .net standard conversion, project reorganization
killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization
URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r311339413
##########
File path: test/nms-openwire-test.csproj
##########
@@ -0,0 +1,66 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <PropertyGroup>
+ <TargetFramework>netcoreapp2.2</TargetFramework>
Review comment:
What is there to this? I changed to `TargetFrameworks` and added net35 and net40 but the solution wont compile now. I also added some itemgroup conditions I saw in the API solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services